Patrick J Banks is one of a few early Edinburgh photographers that
appears not to have been listed in the Edinburgh & Leith Post Office
Directory, so I cannot say when his studio operated.
However the photographs above are both Cabinet Prints. Cabinet
were popular until the end of the 19th century, then their popularity
faded rapidly, with very few being produced after about 1905.
The style of mounts of these photos look to me to be fairly late
examples, so I expect that these photos would probably have been produced within a few
years of 1900.
Perhaps somebody with a knowledge of military uniforms might be able
to say whether or not that date sounds reasonable.
Meadowbank Crescent (the address on the first Cabinet Print) is
fairly close to Piershill ( the address on the second Cabinet Print).
I also have a third cabinet print by Patrick J Banks. Please
click on this thumbnail image to see it: